Always creates SymbolToField "id" instance
#1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hw202207
force-pushed
the
haisheng/always-create-id-symbol-field
branch
from
c02adcb to
beb58c2
Compare
hw202207
force-pushed
the
haisheng/always-create-id-symbol-field
branch
from
beb58c2 to
17cbadb
Compare
- given there is always a {EntityName}Id type
hw202207
force-pushed
the
haisheng/always-create-id-symbol-field
branch
from
4b90e8d to
04728c2
Compare
hw202207
changed the title
SymbolToField "id" instance
parsonsmatt
reviewed
Jun 28, 2023
persistent/ChangeLog.md
Outdated
Comment on lines
3
to
6
| ## Unreleased | ||
|
|
||
| * [1497](https://github.com/yesodweb/persistent/pull/1497) | ||
| * Always generates `SymbolToField "id"` instance |
There was a problem hiding this comment.
This will need to be a minor version bump - may be best to roll up with #1503
There was a problem hiding this comment.
Sounds reasonable to me. Anything I need to do / pay attention to?
There was a problem hiding this comment.
I think I've finished everything that needed to be done in #1503 (re-requested review to be sure). Aside from this PR, is anything else planned for 2.14.6.0?
There was a problem hiding this comment.
I'll rebase after #1503 has been merged (adjust the changelog section)
|
This builds and tests just fine locally so I am going to merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
{EntityName}Idtype hence I think it's safe to always create aSymbolToFieldinstance for ID.